Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stdin for Selene Lua linter #4183

Merged
merged 1 commit into from
May 4, 2022
Merged

Use stdin for Selene Lua linter #4183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ale_linters/lua/selene.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ call ale#Set('lua_selene_options', '')

function! ale_linters#lua#selene#GetCommand(buffer) abort
return '%e' . ale#Pad(ale#Var(a:buffer, 'lua_selene_options'))
\ . ' --display-style=json %s'
\ . ' --display-style=json -'
endfunction

function! ale_linters#lua#selene#Handle(buffer, lines) abort
Expand Down Expand Up @@ -43,5 +43,4 @@ call ale#linter#Define('lua', {
\ 'executable': {b -> ale#Var(b, 'lua_selene_executable')},
\ 'command': function('ale_linters#lua#selene#GetCommand'),
\ 'callback': 'ale_linters#lua#selene#Handle',
\ 'lint_file': 1,
\})
6 changes: 3 additions & 3 deletions test/linter/test_lua_selene.vader
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ After:
call ale#assert#TearDownLinterTest()

Execute(The lua selene command callback should return the correct default string):
AssertLinter 'selene', ale#Escape('selene') . ' --display-style=json %s'
AssertLinter 'selene', ale#Escape('selene') . ' --display-style=json -'

Execute(The lua selene command callback should let you set options):
let g:ale_lua_selene_options = '--num-threads 2'

AssertLinter 'selene',
\ ale#Escape('selene') . ' --num-threads 2 --display-style=json %s'
\ ale#Escape('selene') . ' --num-threads 2 --display-style=json -'

Execute(The selene executable should be configurable):
let g:ale_lua_selene_executable = 'selene.sh'

AssertLinter 'selene.sh', ale#Escape('selene.sh') . ' --display-style=json %s'
AssertLinter 'selene.sh', ale#Escape('selene.sh') . ' --display-style=json -'