-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buf linter and fixer #4128
Add buf linter and fixer #4128
Conversation
It looks like we're seeing a lint failure for the name of the
Is there any way we can make an exception for this one? Given that we're migrating the linter from vim-buf, this would be a breaking change for anyone that removes the dependency on
Plus, I noticed that there is already a |
@amckinney what you can do is set the name using snake case and add an alias. See "cabal_ghc" for example:
|
Thanks for the tip @hsanson, I added the alias and everything works on my end. |
* Add buf lint to linters * Add buf format to fixers * Fix test/linter/test_buf_lint.vader * Fix test/fixers/test_buf_format_fixer_callback.vader * Simplify test/test-files/proto/testfile.proto * Add buf-lint alias and rename linter
* Add buf lint to linters * Add buf format to fixers * Fix test/linter/test_buf_lint.vader * Fix test/fixers/test_buf_format_fixer_callback.vader * Simplify test/test-files/proto/testfile.proto * Add buf-lint alias and rename linter
This adds the
buf lint
command as a linter and thebuf format
command as a fixer. Thebuf lint
linter was previously published from our own vim-buf repository here, whereas thebuf format
fixer is completely new. We'd like both of them to exist inale
now thatbuf
has a stablev1
release.I've included a description and test for each (pattern matching from what previously exists, e.g.
clang-format
,dartfmt
, andgofmt
). I've also verified that both work locally by pointingvim-plug
to my local copy ofale
.I've used the following
.vimrc
configuration to test locally against.proto
files: