Fix broken installation of TS definition files for Deno.
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wrong VS Code Extension ID. Explicitly `await` (and catch) `deno.generateDtsForDeno`, so all definition files are in place, before the extension finishes activation phase. fixes denoland#74, denoland#66, denoland#62, denoland#48
|
A new release would be nice, I think many users are struggling with broken TypeScript definitions (for the |
ry
approved these changes
Jun 6, 2020
This was referenced Jun 6, 2020
Closed
|
@ry There was no update triggered for the plugin in VS Code. If you completely remove the old version and reinstall then this fix is applied. It might be to do with not updating the version number? EDIT: The update also broke this extension for me, now it does nothing #80 (comment) . (It doesn't seem to work at all for many people in the #80 issue thread) |
ry
added a commit
that referenced
this pull request
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong VS Code Extension ID.
Explicitly
await(and catch)deno.generateDtsForDeno, so all definition files are in place, before the extension finishes activation phase.fixes #74, #66, #62, #48