perf(cbor): decodeCbor & decodeCborSequence #6323
Merged
+230
−187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request rewrites the underlying code for
decodeCbor
anddecodeCborSequence
to offer more performance gains via less memory duplication and movement.There is a caveat when decoding definite length Uint8Arrays in that they are being returned as a subarray; meaning their underling buffer
Uint8Array.buffer
is still the entire original input length and changes later to that input will be reflected in these returned Uint8Arrays.Benchmark Source Code
std/cbor/deno.json
std/bench.ts
Benchmark Results