Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli/unstable): rewrite Spinner tests using stub #6254

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Dec 11, 2024

closes #6157
closes #6211

@timreichen timreichen requested a review from kt3k as a code owner December 11, 2024 22:04
@github-actions github-actions bot added the cli label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (7480f35) to head (b5ef858).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6254      +/-   ##
==========================================
- Coverage   96.52%   96.51%   -0.02%     
==========================================
  Files         535      536       +1     
  Lines       41030    41101      +71     
  Branches     6141     6155      +14     
==========================================
+ Hits        39606    39667      +61     
- Misses       1382     1392      +10     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title fix(cli): fix flaky Spinner tests test(cli/unstable): rewrite Spinner tests using stub Dec 12, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work! Thanks

I also updated the test case. Now they are surrounded by try block and restore is called in finally block (By this change, restore is always called even when there's assertion errors in the middle)

@kt3k kt3k merged commit 7416c34 into denoland:main Dec 12, 2024
19 checks passed
@timreichen timreichen deleted the fix-flacky-spinner-tests branch December 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewrite Spinner test using @std/testing/mock Flaky spinner test "Spinner constructor accepts interval"
2 participants