Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli/unstable): cleanup promptSelect() tests #6253

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Dec 11, 2024

This PR renames some tests and uses an array to store outputs that are compared with the expected outputs instead of comparing each output.

@timreichen timreichen requested a review from kt3k as a code owner December 11, 2024 21:28
@github-actions github-actions bot added the cli label Dec 11, 2024
@kt3k
Copy link
Member

kt3k commented Dec 12, 2024

This branch seems to have started from the old state of main before #6221. Can you fix the conflicts?

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (283cf34) to head (cfb6760).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6253   +/-   ##
=======================================
  Coverage   96.49%   96.50%           
=======================================
  Files         536      536           
  Lines       41179    41179           
  Branches     6175     6175           
=======================================
+ Hits        39734    39738    +4     
+ Misses       1403     1399    -4     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timreichen
Copy link
Contributor Author

This branch seems to have started from the old state of main before #6221. Can you fix the conflicts?

Done.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k changed the title chore(cli): cleanup promptSelect() tests test(cli/unstable): cleanup promptSelect() tests Dec 13, 2024
@kt3k kt3k merged commit cc9a7c0 into denoland:main Dec 13, 2024
20 checks passed
@timreichen timreichen deleted the cleanup-promptSelect()-tests branch December 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants