Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): handle HEAD requests in serveFile #6218

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

crowlKats
Copy link
Member

No description provided.

@crowlKats crowlKats requested a review from kt3k as a code owner November 28, 2024 11:40
@github-actions github-actions bot added the http label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (09e426b) to head (d3a3637).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6218      +/-   ##
==========================================
- Coverage   96.53%   96.53%   -0.01%     
==========================================
  Files         534      534              
  Lines       40942    40952      +10     
  Branches     6131     6133       +2     
==========================================
+ Hits        39523    39532       +9     
- Misses       1377     1378       +1     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title fix(http): handle head requests in serveFile fix(http): handle HEAD requests in serveFile Nov 28, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 18cb34b into denoland:main Nov 29, 2024
19 checks passed
@crowlKats crowlKats deleted the serve-file-handle-head-request branch November 29, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants