Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): re-align expect.toMatchObject api #6160

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

eryue0220
Copy link
Contributor

This pr is to re implement expect.toMatchObject api.

Close: #6152 and #6111

@eryue0220 eryue0220 requested a review from kt3k as a code owner October 30, 2024 14:00
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 81.18812% with 19 lines in your changes missing coverage. Please review.

Project coverage is 96.48%. Comparing base (689fb69) to head (9646778).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
expect/_utils.ts 80.30% 13 Missing ⚠️
expect/_matchers.ts 78.57% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6160      +/-   ##
==========================================
- Coverage   96.53%   96.48%   -0.05%     
==========================================
  Files         538      538              
  Lines       40902    40969      +67     
  Branches     6150     6162      +12     
==========================================
+ Hits        39483    39530      +47     
- Misses       1375     1395      +20     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! @eryue0220

@kt3k kt3k merged commit 32b4fb6 into denoland:main Nov 1, 2024
19 checks passed
@eryue0220 eryue0220 deleted the fix/expect-to-strict-equal branch November 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@std/expect toStrictEqual() on objects mis-compute their length
2 participants