Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: complete docs for std/jsonc #4814

Merged
merged 3 commits into from
May 22, 2024
Merged

fix: complete docs for std/jsonc #4814

merged 3 commits into from
May 22, 2024

Conversation

igorzi
Copy link
Contributor

@igorzi igorzi commented May 21, 2024

No description provided.

@igorzi igorzi requested a review from littledivy May 21, 2024 18:07
@igorzi igorzi requested a review from kt3k as a code owner May 21, 2024 18:07
@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@igorzi igorzi enabled auto-merge (squash) May 21, 2024 18:07
@github-actions github-actions bot added the jsonc label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (345854c) to head (03e5fd0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4814      +/-   ##
==========================================
- Coverage   91.94%   91.51%   -0.44%     
==========================================
  Files         486      486              
  Lines       41353    41353              
  Branches     5321     5284      -37     
==========================================
- Hits        38024    37844     -180     
- Misses       3272     3450     +178     
- Partials       57       59       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Igor!

@igorzi igorzi merged commit 0248c18 into main May 22, 2024
12 checks passed
@igorzi igorzi deleted the jsonc_docs branch May 22, 2024 06:03
@kt3k kt3k mentioned this pull request May 23, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants