Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): removed unused code from Wasm build #4510

Merged
merged 8 commits into from
Mar 23, 2024

Conversation

jeremyBanks
Copy link
Contributor

The std/crypto/_wasm build currently exports several functions that are no longer called anywhere and are just bloat. This PR removes them and their supporting code. This reduces the size of deno_std_wasm_crypto.generated.mjs from 237,510B to 194,324B on disk (18% reduction) and from 88,596 B to 77,230B after gzip --best (13% reduction).

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup! LGTM! Thank you.

@iuioiua iuioiua enabled auto-merge (squash) March 23, 2024 01:56
@iuioiua iuioiua merged commit d78b585 into denoland:main Mar 23, 2024
12 checks passed
@jeremyBanks jeremyBanks deleted the crypto-wasm-cleanup branch March 23, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants