Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log): add missing return types #4401

Merged
merged 4 commits into from
Feb 27, 2024
Merged

fix(log): add missing return types #4401

merged 4 commits into from
Feb 27, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Feb 26, 2024 •
edited
Loading

Some upcoming work should prevent this from happening again.

Fixes https://github.com/denoland/deno_std/actions/runs/8054065477/job/21997810452

@iuioiua iuioiua requested a review from kt3k as a code owner February 26, 2024 21:07
@github-actions github-actions bot added the log label Feb 26, 2024
@iuioiua iuioiua enabled auto-merge (squash) February 26, 2024 21:07
@iuioiua iuioiua marked this pull request as draft February 26, 2024 22:21
auto-merge was automatically disabled February 26, 2024 22:21

Pull request was converted to draft

@iuioiua iuioiua marked this pull request as ready for review February 27, 2024 18:44
@iuioiua iuioiua merged commit 4bcdea8 into main Feb 27, 2024
10 checks passed
@iuioiua iuioiua deleted the log-missing-return-types branch February 27, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @bartlomieju