Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOML] Move to encoding #435

Merged
merged 4 commits into from
May 23, 2019
Merged

[TOML] Move to encoding #435

merged 4 commits into from
May 23, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented May 22, 2019

as mentionned in : #431
Move toml to encoding.
Also added a cleanup using fs/EOL

@zekth
Copy link
Contributor Author

zekth commented May 23, 2019

Regarding comment in : #432

Adjusted the path

ry
ry reviewed May 23, 2019
View reviewed changes
encoding/toml.ts Outdated Show resolved Hide resolved
encoding/toml.ts Outdated Show resolved Hide resolved
ry
ry approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 7a722ce into denoland:master May 23, 2019
@zekth zekth deleted the move_toml branch May 23, 2019 18:57
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@zekth @ry
TOML: Move to encoding dir (denoland/std#435)
0803912 

Original: denoland/std@7a722ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zekth @ry