Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datetime): format() options #4285

Merged
merged 6 commits into from
Feb 9, 2024
Merged

feat(datetime): format() options #4285

merged 6 commits into from
Feb 9, 2024

Conversation

babiabeo
Copy link
Contributor

@babiabeo babiabeo commented Feb 7, 2024

Fix: #4284

@babiabeo babiabeo requested a review from kt3k as a code owner February 7, 2024 14:51
iuioiua
iuioiua suggested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey David, could we add the following to datetime/format.ts instead?

export interface FormatOptions {
  utc?: boolean;
}

We should also have accompanying documentation. WDYT?

@babiabeo
Copy link
Contributor Author

babiabeo commented Feb 8, 2024

Hey David, could we add the following to datetime/format.ts instead?

export interface FormatOptions {

  utc?: boolean;

}

We should also have accompanying documentation. WDYT?

Updated 👍

iuioiua
iuioiua reviewed Feb 9, 2024
View reviewed changes
datetime/format.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! I'll let Yoshiya review too.

@iuioiua iuioiua changed the title fix(datetime): allow passing options to format() feat(datetime): allow passing options to format() Feb 9, 2024
@iuioiua iuioiua changed the title feat(datetime): allow passing options to format() feat(datetime): format() options Feb 9, 2024
kt3k
kt3k approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition makes sense to me. LGTM

@kt3k kt3k merged commit 2b5149e into denoland:main Feb 9, 2024
12 checks passed
@babiabeo babiabeo deleted the add-format-opt branch February 9, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
datetime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing arguments to std/datetime/format()
3 participants
@babiabeo @kt3k @iuioiua