Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(async): deprecate deferred() in favor of Promise.withResolvers() #3758

Merged
merged 13 commits into from
Nov 10, 2023
Merged

BREAKING(async): deprecate deferred() in favor of Promise.withResolvers() #3758

merged 13 commits into from
Nov 10, 2023

Conversation

lino-levan
Copy link
Contributor

closes #3757

@lino-levan lino-levan requested a review from kt3k as a code owner November 1, 2023 18:11
@github-actions github-actions bot added the async label Nov 1, 2023
lucacasonato
lucacasonato reviewed Nov 1, 2023
View reviewed changes
async/deferred.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua suggested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll confirm this removal version before merging. But it's also good to link to docs like this going forward. This should fail on stable but pass on canary.

async/deferred.ts Outdated Show resolved Hide resolved
async/deferred.ts Outdated Show resolved Hide resolved
async/deferred.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua changed the title BREAKING(async): Deprecate deferred in favor of Promise.withResolvers BREAKING(async): deprecate deferred() in favor of Promise.withResolvers() Nov 1, 2023
iuioiua
iuioiua suggested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yoshiya and I agreed that a deprecation period of 2 minor versions (12 weeks) is reasonable. Let's go with that.

async/deferred.ts Outdated Show resolved Hide resolved
async/deferred.ts Outdated Show resolved Hide resolved
@lino-levan @iuioiua
Apply suggestions from code review
0b3d00d 
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
iuioiua
iuioiua approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Lino!

iuioiua
iuioiua reviewed Nov 6, 2023
View reviewed changes
async/deferred.ts Outdated Show resolved Hide resolved
async/deferred.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke with Yoshiya again, and we'll reduce the deprecation period for this to 1 minor version (6 weeks). We'll likely merge this PR right before the next minor release. LGTM again and thanks again!

iuioiua
iuioiua approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again for the change. I previously misunderstood specifics around the deprecation period. Either way, I've now changed this to be removed in 0.209.0 and can now merge. Thanks again for this, Lino!

@iuioiua iuioiua merged commit 7e6a91f into denoland:main Nov 10, 2023
11 checks passed
@lino-levan lino-levan deleted the deprecate-async-deferred branch November 10, 2023 00:30
@iuioiua iuioiua mentioned this pull request Nov 10, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
async
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate "deferred" API
3 participants
@lino-levan @lucacasonato @iuioiua