fix: flaky http/file_server.ts tests
#3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
changed the title
serveDirIndex TLS testhttp/file_server.ts tests
kt3k
reviewed
Oct 25, 2023
| const res = await fetch("https://localhost:4577/", { client }); | ||
| client.close(); | ||
|
|
||
| assertStringIncludes(await res.text(), "<title>Deno File Server</title>"); | ||
| } finally { | ||
| await killFileServer(); | ||
| } | ||
| }, | ||
| ); | ||
|
|
||
| Deno.test("partial TLS arguments fail", async function () { |
There was a problem hiding this comment.
I don't think we need to change this test case because according to this run log https://github.com/denoland/deno_std/actions/runs/6625309968/job/17996042005?pr=3715 this test case was affected by the one above (i.e. the flakiness wasn't caused by this test case itself)
There was a problem hiding this comment.
I understand. However, passing by, I realised the test could rely on more reliable APIs. Hence, the change.
|
flakiness happened in other places, but this one looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3716