Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): file server with showDirListing + urlRoot #3691

Merged
merged 5 commits into from
Oct 23, 2023
Merged

fix(http): file server with showDirListing + urlRoot #3691

merged 5 commits into from
Oct 23, 2023

Conversation

lino-levan
Copy link
Contributor

Closes #3690

@lino-levan lino-levan requested a review from kt3k as a code owner October 10, 2023 15:05
@github-actions github-actions bot added the http label Oct 10, 2023
kt3k
kt3k approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thanks! (Tested manually)

@kt3k kt3k merged commit 4890b47 into denoland:main Oct 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

serveDir links are incorrect when urlRoot is set.
2 participants
@lino-levan @kt3k