Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log): rotating file handler sync setup and destroy #3543

Merged
merged 4 commits into from
Aug 29, 2023
Merged

fix(log): rotating file handler sync setup and destroy #3543

merged 4 commits into from
Aug 29, 2023

Conversation

lino-levan
Copy link
Contributor

Closes #3538

@lino-levan lino-levan marked this pull request as ready for review August 15, 2023 23:39
@lino-levan lino-levan requested a review from kt3k as a code owner August 15, 2023 23:39
@github-actions github-actions bot added the log label Aug 15, 2023
@ross-weir ross-weir mentioned this pull request Aug 17, 2023
Closed
@lino-levan
Copy link
Contributor Author

Failing on the same flaky test, rather unfortunate. Why is this only coming up recently?

@kt3k
Copy link
Member

kt3k commented Aug 25, 2023

Failing on the same flaky test, rather unfortunate. Why is this only coming up recently?

Probably because of the parallel execution of tests #3446

kt3k
kt3k approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 75e02c7 into denoland:main Aug 29, 2023
@lino-levan lino-levan deleted the fix-log-rotating-file-handler branch August 29, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log handler setup function is inconsistent
2 participants
@lino-levan @kt3k