Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(json): Primitives at top level without separator #3466

Merged
merged 1 commit into from
Jun 27, 2023
Merged

feat(json): Primitives at top level without separator #3466

merged 1 commit into from
Jun 27, 2023

Conversation

grimly
Copy link
Contributor

@grimly grimly commented Jun 24, 2023

Hello,

I am consuming an API that uses concatenated JSON when streaming.
I came across the issue this API sent nullnull in the stream.

I can't really blame the API because they are clearly saying they have no separator between JSON values and null is valid for their API.

I updated the transformer to allow for null, true and false at top level without any separation at all.

Best regards,
Michel

@grimly grimly requested a review from kt3k as a code owner June 24, 2023 22:25
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit deddc2a into denoland:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants