fix(http/file_server): resolve empty subdir correctly on Windows #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One goal of this commit is to avoid tripping over the 'current directory read permission' prompt from deno. The prompt should not happen in the case when we already specified a path to the `--allow-read` argument. This prompt can be seen when navigating to a subdir in a browser while running a deno server from Windows. This is because file_server mixed different path separators when building paths and then pass it to `Deno.stat()`. However `Deno.stat()` doesn't seem to handle it well and therefore generated the prompt.
kt3k
added a commit
to kt3k/deno_std
that referenced
this pull request
Jun 13, 2023
kt3k
added a commit
to kt3k/deno_std
that referenced
this pull request
Jun 13, 2023
|
ref #3444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One goal of this commit is to avoid tripping over the 'current directory read permission' prompt from deno.
The prompt should not happen in the case when we already specified a path to the
--allow-readargument.This prompt can be seen when navigating to a subdir in a browser while running a deno server from Windows. This is because file_server mixed different path separators when building paths and then pass it to
Deno.stat(). HoweverDeno.stat()doesn't seem to handle it well and therefore generated the prompt.