Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): report the number of removed snapshots #3435

Merged
merged 2 commits into from
Jun 10, 2023
Merged

feat(testing): report the number of removed snapshots #3435

merged 2 commits into from
Jun 10, 2023

Conversation

wafuwafu13
Copy link
Contributor

close #2143

@wafuwafu13 wafuwafu13 requested a review from kt3k as a code owner June 8, 2023 22:08
wafuwafu13
wafuwafu13 commented Jun 8, 2023
View reviewed changes
testing/snapshot.ts
);
for (const snapshotName of removedSnapshotNames) {
console.log(
red(bold(` • ${snapshotName}`)),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: https://github.com/jestjs/jest/blob/6460335f88cee3dcb9d29c49d55ab02b9d83f994/packages/jest-reporters/src/__tests__/__snapshots__/getSnapshotStatus.test.js.snap#L9

kt3k
kt3k approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@kt3k kt3k merged commit d3e4857 into denoland:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assertSnapshot should report the number of snapshots removed
2 participants
@wafuwafu13 @kt3k