refactor(testing): remove unnecessary context processing in snapshot teardown #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Jun 5, 2023
Comment on lines
+565
to
+567
| await assertSnapshot(t, formatTestOutput(result1.output), { | ||
| name: "Snapshot Test - Different Dir - New snapshot", | ||
| }); |
There was a problem hiding this comment.
I think this assertion is enough for checking this change isn't breaking things. Can you remove the rest of assertions and reduce the new snapshots?
I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/denoland/deno_std/blob/2d9dd290f03e6edf8913fb0de7b9b0becb934e16/testing/snapshot.ts#L337
This
contextslength is always 1 becauseteardownis only called once in a context.https://github.com/denoland/deno_std/blob/2d9dd290f03e6edf8913fb0de7b9b0becb934e16/testing/snapshot.ts#L530
https://github.com/denoland/deno_std/blob/2d9dd290f03e6edf8913fb0de7b9b0becb934e16/testing/snapshot.ts#L410-L415