Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flags): Correctly collect default value #3380

Merged
merged 1 commit into from
May 15, 2023
Merged

fix(flags): Correctly collect default value #3380

merged 1 commit into from
May 15, 2023

Conversation

kamilogorek
Copy link
Contributor

Fixes #3376

@kamilogorek kamilogorek requested a review from kt3k as a code owner May 14, 2023 15:09
kt3k
kt3k approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit aebc8c7 into denoland:main May 15, 2023
@kt3k
Copy link
Member

kt3k commented May 15, 2023

cc @c4spar

@kamilogorek kamilogorek deleted the flags-collectible-defaults branch May 15, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std/flags: Using collect and default together results in a nested array
2 participants
@kamilogorek @kt3k