feat(async): support signal
on deadline()
like delay()
#3347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the subject suggests, I have added support for the signal parameter in the
deadline()
function. This change is useful to clean up dangling promises for tests like:Without the signal parameter, the above test fails with the following error:
Note that the comment on
deadline
suggests usingAbortSignal.timeout(...)
instead. However, the signal itself cannot be manually aborted (yet), sodeadline()
is still useful in such cases.