-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(html): Add escape and unescape functions for HTML entities #3335
Conversation
Maybe we should rename |
+1 |
Bikeshedding: encode/decode vs. escape/unescape vs [any other options]? I don't have a strong preference. |
9e757f6
to
6ef5b6c
Compare
+1 for escape and unescape |
4ffdfb3
to
27dcd21
Compare
27dcd21
to
4386708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Memo:
|
Honorable mention also to htmlentities and html_entity_decode in PHP, which use a full list of named entities. Also worth considering the bit of the HTML spec that deals with escaping text nodes and attribute nodes:
|
@lionel-rowe Thanks for your contribution! |
Fixes #3329