Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uuid): uuid v3 #3324

Merged
merged 6 commits into from
Apr 25, 2023
Merged

feat(uuid): uuid v3 #3324

merged 6 commits into from
Apr 25, 2023

Conversation

lino-levan
Copy link
Contributor

Discussed a bit on discord, no one objected at the time.

@lino-levan lino-levan requested a review from kt3k as a code owner April 19, 2023 15:53
@lino-levan lino-levan changed the title feat: uuid v3 feat(uuid): uuid v3 Apr 19, 2023
uuid/v3.ts Outdated Show resolved Hide resolved
uuid/v3.ts Outdated Show resolved Hide resolved
@lino-levan
Copy link
Contributor Author

Ah sorry for the sloppy PR, I mean to open it as a draft. Will look into changes this weekend.

@lino-levan lino-levan requested a review from kt3k April 23, 2023 14:59
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@@ -31,10 +31,10 @@ export function validate(id: string): boolean {
* ```js
* import { generate } from "https://deno.land/std@$STD_VERSION/uuid/v5.ts";
*
* const NAMESPACE_URL = "6ba7b810-9dad-11d1-80b4-00c04fd430c8";
* const NAMESPACE_URL = "6ba7b811-9dad-11d1-80b4-00c04fd430c8";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kt3k kt3k merged commit 934cb11 into denoland:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants