Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(csv): rename CsvStream to CsvParseStream #3287

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Mar 27, 2023

Follow-up to #3270

This PR renames CsvStream to CsvParseStream. This change is intended to improve consistency with std/json, which provides JsonParseStream and JsonStringifyStream.

@uki00a uki00a requested a review from kt3k as a code owner March 27, 2023 17:08
@iuioiua
Copy link
Contributor

iuioiua commented Mar 29, 2023

LGTM!

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@uki00a Could you resolve the merge conflict with main?

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating! LGTM

@kt3k kt3k merged commit 1fd4991 into denoland:main Apr 5, 2023
@uki00a uki00a deleted the rename-CsvStream-to-CsvParseStream branch April 5, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants