Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(encoding/varint): remove deprecated APIs #3282

Merged
merged 6 commits into from
Apr 3, 2023
Merged

BREAKING(encoding/varint): remove deprecated APIs #3282

merged 6 commits into from
Apr 3, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Mar 26, 2023

Please do not merge until version 0.182.0 is published.

This PR removes Rust-based APIs of encoding/varint in favour of the new pure TypeScript implementation as a continuation of #3215.

@iuioiua iuioiua marked this pull request as ready for review March 31, 2023 19:54
@iuioiua iuioiua requested a review from kt3k as a code owner March 31, 2023 19:54
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice clean up!

@kt3k kt3k merged commit d02b577 into denoland:main Apr 3, 2023
@iuioiua iuioiua deleted the remove-varint branch April 3, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants