Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add http/etag #3245

Merged
merged 9 commits into from
Apr 12, 2023
Merged

feat: add http/etag #3245

merged 9 commits into from
Apr 12, 2023

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Mar 8, 2023

This is based on the etag handling in oak as well as the file_server as part of std and extracts that out into a re-usable library.

@kitsonk kitsonk requested a review from kt3k as a code owner March 8, 2023 23:06
http/etag.ts Show resolved Hide resolved
http/etag.ts Outdated Show resolved Hide resolved
http/etag.ts Show resolved Hide resolved
http/etag.ts Show resolved Hide resolved
Copy link
Contributor

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of a few nitpicks, this looks good to me.

http/etag.ts Outdated Show resolved Hide resolved
http/etag.ts Outdated Show resolved Hide resolved
http/etag.ts Outdated Show resolved Hide resolved
http/etag.ts Outdated Show resolved Hide resolved
@kitsonk kitsonk requested a review from kt3k April 7, 2023 00:51
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

http/util.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants