Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make encoding/front_matter work in a browser #3154

Merged
merged 1 commit into from
Feb 2, 2023
Merged

fix: make encoding/front_matter work in a browser #3154

merged 1 commit into from
Feb 2, 2023

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Feb 1, 2023

This safely access the Deno namespace so encoding/front_matter can be used in a browser (like an interactive island in Fresh).

@kitsonk kitsonk requested a review from kt3k as a code owner February 1, 2023 02:34
kt3k
kt3k approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 1, 2023

Sadly I cannot merge anymore! 😁

@kt3k kt3k merged commit df0e69a into denoland:main Feb 2, 2023
@kt3k kt3k mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitsonk @kt3k