Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract internal method isSubdir to fs/utils.ts #285

Merged
merged 5 commits into from
Mar 17, 2019
Merged

extract internal method isSubdir to fs/utils.ts #285

merged 5 commits into from
Mar 17, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Mar 16, 2019 •
edited
Loading

This method is also used in #278, so extract it first as an internal method.

ry
ry reviewed Mar 16, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to fs/utils.ts ?

@axetroy axetroy changed the title extract internal method isSubdir to path modules extract internal method isSubdir to fs/utils.ts Mar 17, 2019
@axetroy
Copy link
Contributor Author

axetroy commented Mar 17, 2019

@ry yes. move to fs/utils.ts

ry
ry approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit da4abcd into denoland:master Mar 17, 2019
@axetroy axetroy deleted the is_sub_dir branch March 17, 2019 16:35
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@axetroy @ry
extract internal method isSubdir to fs/utils.ts (denoland/std#285)
942df0b 
Original: denoland/std@da4abcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axetroy @ry