Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add CODEOWNERS file #1550

Merged
merged 1 commit into from
Nov 11, 2021
Merged

ci: add CODEOWNERS file #1550

merged 1 commit into from
Nov 11, 2021

Conversation

lowlighter
Copy link
Contributor

Closes #1472

Originally posted by bartlomieju October 26, 2021
We should have a bot that automatically requests a review from one of maintainers for PRs.

In the beginning it could assign either me or kt3k

This uses GitHub's codeowners feature, which automatically request a review from maintainers depending on which files were edited. In addition, the UI will also display which reviewers will be mandated when browsing files directly on GitHub:

I'll leave bartlomieju and kt3k as suggested in initial issue

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2021

CLA assistant check
All committers have signed the CLA.

@@ -0,0 +1,34 @@
# github folder and all project root files (readme, license, general config, etc.)
.github/ @bartlomieju @kt3k
/* @bartlomieju @kt3k
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This glob specifically matches all files located on project root (like deno.json, LICENSE, etc.)

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju What do you think?

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, let's start with this and tweak it as we go

@bartlomieju bartlomieju merged commit afa5c51 into denoland:main Nov 11, 2021
traceypooh pushed a commit to traceypooh/deno_std that referenced this pull request Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up bot that automatically requests review
4 participants