Improve assert #124
Merged
Improve assert #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2019
ry
reviewed
Jan 16, 2019
ry
reviewed
Jan 16, 2019
ry
reviewed
Jan 16, 2019
ry
reviewed
Jan 16, 2019
ry
reviewed
Jan 16, 2019
ry
reviewed
Jan 16, 2019
ry
reviewed
Jan 16, 2019
ry
reviewed
Jan 16, 2019
|
@ry counters added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
assertin thetestingmodule.It decorates the
assertfunction with three additional functions for assertion:assert.equal()- This is the same asassertEqual()already present.assert.strictEqual()- This checks thatactualandexpectedare strictly equal.assert.throws()- This takes a function which is expected to throw. If it does not, then the assertion will throw. It can also take optional error class, where the class of the thrown error is checked, and a string which should be included in the thrown error message.