Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remaining Node.js builtin aliases #1085

Merged
merged 2 commits into from
Aug 1, 2021

Conversation

guybedford
Copy link
Contributor

This adds the remaining Node.js aliases:

  • path/posix
  • path/win32
  • stream/promises
  • timers/promises
  • util/types

Which combined with #1083 and #1084 covers all the aliases.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @guybedford thank you very much for opening these PRs, improvements to the Node compatibility layer are always very welcome!

@bartlomieju bartlomieju merged commit bd36925 into denoland:main Aug 1, 2021
@guybedford guybedford deleted the aliases branch August 1, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants