fix(encoding/base64url): throw TypeError in case of invalid base64url string #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Jul 19, 2021
encoding/base64url.ts
Outdated
| @@ -17,6 +17,10 @@ export function addPaddingToBase64url(base64url: string): string { | |||
| } | |||
|
|
|||
| function convertBase64urlToBase64(b64url: string): string { | |||
| if (!/^[-_A-Z0-9]*?={0,2}$/i.test(b64url)) { | |||
| // Contains characters not part of base64url spec. | |||
| throw new TypeError("Invalid base64url character in string!"); | |||
There was a problem hiding this comment.
Maybe we should align the error message with base64.decode like:
throw new TypeError("Failed to decode base64url: invalid character);BTW @lucacasonato do you think the error here should be DOMException?
There was a problem hiding this comment.
Changed, for the time being. Awaiting input on whether or not this should be a DOMException.
|
The test case looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1011
Validate input in base64url decoder.
Add tests for making sure invalid base64url strings are rejected.