Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(encoding/toml): parse keys correctly #1019

Merged
merged 4 commits into from
Jul 13, 2021
Merged

fix(encoding/toml): parse keys correctly #1019

merged 4 commits into from
Jul 13, 2021

Conversation

FujiHaruka
Copy link
Contributor

Fix #1018

Fix all cases shown at #1018 description.

kt3k
kt3k approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FujiHaruka Thanks! LGTM

Confirmed this matches the result of @iarna/toml parser. ref

@kt3k kt3k merged commit bac1c3e into denoland:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(encoding/toml) TOML parser incorrectly parses keys
2 participants
@FujiHaruka @kt3k