Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why noLib: true is set in tsconfig.json? #407

Closed
keroxp opened this issue May 14, 2019 · 1 comment · Fixed by #416
Closed

why noLib: true is set in tsconfig.json? #407

keroxp opened this issue May 14, 2019 · 1 comment · Fixed by #416

Comments

@keroxp
Copy link
Contributor

keroxp commented May 14, 2019 •
edited
Loading

スクリーンショット 2019-05-15 2 39 12

I'm using type definition file generated by deno types > deno.d.ts while developing. But IDE shows many symbol errors as noLib: true is set in tsconfig.json. Why noLib: true is needed? Doesn't deno explicitly refer to esnext lib?
@kitsonk
Copy link
Contributor

kitsonk commented May 14, 2019

There was a change of behaviour in TypeScript 3.2 in regards to noLib and the tsconfig should be changed to remove that and be more like https://github.com/kitsonk/deno_example

@keroxp keroxp mentioned this issue May 18, 2019
Merged
@ry ry closed this as completed in #416 May 18, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
@hashrock @iuioiua
doc: add a link to auth setup guide (denoland#407)
fec9859 
Just an idea, how about issuing an instruction when `GITHUB_CLIENT_ID`
and `GITHUB_CLIENT_SECRET` are not set? I think It reduces the feeling
of emptyness after initial setup, and it will prevent users from getting
lost in both the local environment and the Deno Deploy environment.

If these environment variables are not required, I think this PR is not
appropriate and should be closed.

Feel free to rewrite the text if you like this idea.

<img width="967" alt="image"
src="https://github.com/denoland/saaskit/assets/3132889/a9f54103-a677-4f54-aab2-477d36a65179">

<img width="963" alt="image"
src="https://github.com/denoland/saaskit/assets/3132889/7bdaef5f-666c-4813-9114-e17c83b7f1f6">

---------

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add exnext lib to tsconfig.json keroxp/deno_std
2 participants
@keroxp @kitsonk