-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement strict mode in std
#213
Comments
Yes - we need TSLint here. |
Actually, ESLint. See denoland/deno#1824... TSLint is moving itself into ESLint. |
With ESLing in CI pipeline can we close this issue? |
No, this is more than that. Now that |
Thanks for comment @kitsonk, I'll look into it |
Deno runs in non-strict mode, in the Deno core though, we enforce strict mode. I think we should enforce that for
std
. I am seeing a lot of code in here that is not compliant with strict mode, which allows a lot of unsafe assignments aroundnull
andundefined
as well as quite a few other violations which make the code unsound.We also have quite a few linting violations too, which we catch in core, which are not being caught in our code review, like unused variables,
let
s where no reassignment occurs, etc...My opinion is we need to find a way to enforce these as part of the CI process before it gets too far out of hand.
The text was updated successfully, but these errors were encountered: