Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESLint #1824

Closed
kitsonk opened this issue Feb 21, 2019 · 11 comments
Closed

Migrate to ESLint #1824

kitsonk opened this issue Feb 21, 2019 · 11 comments
Labels
build build system or continuous integration related

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Feb 21, 2019

The TypeScript team announced a couple months ago that they were focusing internally on migrating to ESLint from tslint and then earlier this week tslint mentioned that they were deprecating tslint and joining forces with ESLint.

Therefore I think it only makes sense we migrate to ESLint. It would also be a good point to re-evaluate our linting rules and ensure that we extend our rules based on ignoring anything that Prettier handles (currently there are a couple conflicts between Prettier and tslint we have to add ignore comments for).

@ry
Copy link
Member

ry commented Feb 21, 2019

Do you have a link to that announcement ?

@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 21, 2019

@ry
Copy link
Member

ry commented Feb 21, 2019

Thanks. Yes I'm all for this.

@ry ry added this to the future milestone Feb 21, 2019
@ry ry added the build build system or continuous integration related label Feb 21, 2019
@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 21, 2019

cc/ @JamesHenry

Any thoughts on migration approach appreciated.

@j-f1
Copy link
Contributor

j-f1 commented Feb 22, 2019

Check out our docs on equivalents for TSLint rules for some guidance.

@kitsonk
Copy link
Contributor Author

kitsonk commented Feb 22, 2019

@j-f1 any good standard configs you can recommend. I am not totally a fan of our current rules.

@j-f1
Copy link
Contributor

j-f1 commented Feb 22, 2019

We’ve got a recommended config (plugin:@typescript-eslint/recommended, rules are marked with a ✔️ here) for TypeScript-specific linting, and for general JS support, Airbnb or the default eslint:recommended config are common options. I strongly recommend Prettier for linting formatting, and using eslint-plugin-prettier to disable any formatting rules in the other configs.

@balupton
Copy link
Contributor

balupton commented Apr 7, 2019

Perhaps https://discuss.bevry.me/t/how-bevry-automates-maintenance-of-its-prolific-open-source-portfolio/693?u=balupton and https://github.com/bevry/eslint-config-bevry would be useful as it detects the needs of the project and adapts the linting accordingly

@ry
Copy link
Member

ry commented Apr 7, 2019

This was completed in #1905

@ry ry closed this as completed Apr 7, 2019
@romainPrignon
Copy link
Contributor

Hello :)
Is there any doc about eslint-typescript integration ?
I search on https://deno.land/manual.html and https://deno.land/manual.html and https://deno.land/style_guide.html but I found nothing :(

@JustFly1984
Copy link

Eslint plugin deno, and VSCode extension could be amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build system or continuous integration related
Projects
None yet
Development

No branches or pull requests

6 participants