fix(semver): add a necessary grouping, fix prerelease parsing (#3674)

denoland · Sep 25, 2023 · 2884033 · 2884033
1 parent ea9dbdb
commit 2884033
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/semver/parse.ts b/semver/parse.ts
@@ -56,7 +56,7 @@ export function parse(version: string | SemVer): SemVer {
   }
 
   // number-ify any prerelease numeric ids
-  const numericIdentifier = new RegExp(`^${src[NUMERICIDENTIFIER]}$`);
+  const numericIdentifier = new RegExp(`^(${src[NUMERICIDENTIFIER]})$`);
   const prerelease = (m[4] ?? "")
     .split(".")
     .filter((id) => id)

diff --git a/semver/parse_test.ts b/semver/parse_test.ts
@@ -73,6 +73,8 @@ Deno.test("prerelease", async (t) => {
     ["1.0.0-beta.2", ["beta", 2]],
     ["v0.5.4-pre", ["pre"]],
     ["1.2.2-alpha.1", ["alpha", 1]],
+    ["1.2.0-1b3-4", ["1b3-4"]],
+    ["1.2.0-3.6-pre2", [3, "6-pre2"]],
     ["2.0.0", []],
   ];