Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only call /api/me/votes when being signed in #534

Merged
merged 3 commits into from
Sep 8, 2023
Merged

fix: only call /api/me/votes when being signed in #534

merged 3 commits into from
Sep 8, 2023

Conversation

mbhrznr
Copy link
Contributor

@mbhrznr mbhrznr commented Sep 7, 2023

closes #522.

iuioiua
iuioiua reviewed Sep 8, 2023
View reviewed changes
islands/ItemsList.tsx Outdated Show resolved Hide resolved
@iuioiua iuioiua mentioned this pull request Sep 8, 2023
Merged
iuioiua
iuioiua approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some edits and now, LGTM! Thank you, Michael.

@iuioiua iuioiua changed the title chore: only call /api/me/votes when being signed in fix: only call /api/me/votes when being signed in Sep 8, 2023
@iuioiua iuioiua merged commit 5cbfd3c into denoland:main Sep 8, 2023
@iuioiua iuioiua mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

todo(perf): avoid calling GET /api/me/votes if user is not signed in
2 participants
@mbhrznr @iuioiua