-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OAuth #35
feat: OAuth #35
Conversation
Thanks @iuioiua , and sorry for the delay on PCKE. We needed to fix some issues in gotrue-js but those have now been released. Hoping we'll land PCKE support in the auth helpers by end of week! |
Not a problem! One of the reasons I made this PR was so that we can directly see the improvement once PKCE has landed. |
@thorwebdev, does the implementation look sound to you? It was taken from https://github.com/thorwebdev/everydaylytics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM 👍
Other part looks good to me. |
Changes made:
|
This change adds OAuth functionality for authentication. So far, GitHub is used as an example.
I'm aware that this approach is suboptimal compared to the incoming PKCE approach but would rather enable OAuth sooner rather than later. We'll switch to PKCE once available.
Towards #13.
@thorwebdev and @kt3k , WDYT?