Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(db): test compareScore() and getAreVotedBySessionId() #300

Merged
merged 7 commits into from
Jul 2, 2023
Merged

tests(db): test compareScore() and getAreVotedBySessionId() #300

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a84426f
tests(db): compareScore and getAreVotedBySessionId
niklasmtj Jun 25, 2023
69d9ad5
Merge branch 'main' into tests/compare-scores-and-voted-by-sessionid
iuioiua Jun 30, 2023
19e3e33
chore: add falsy user tests
niklasmtj Jul 1, 2023
153f423
tests: `compareScore()` uses array now
niklasmtj Jul 1, 2023
8a01086
tests: check for falsy and wrong session values
niklasmtj Jul 2, 2023
9585414
Merge branch 'main' into tests/compare-scores-and-voted-by-sessionid
niklasmtj Jul 2, 2023
f37a628
tests: use `assertEquals()`
niklasmtj Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions utils/db_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright 2023 the Deno authors. All rights reserved. MIT license.
import {
type Comment,
compareScore,
createComment,
createItem,
createUser,
Expand All @@ -11,6 +12,7 @@ import {
deleteVote,
formatDate,
getAllItems,
getAreVotedBySessionId,
getCommentsByItem,
getDatesSince,
getItem,
Expand Down Expand Up @@ -236,3 +238,70 @@ Deno.test("[db] getDatesSince()", () => {
formatDate(new Date()),
]);
});

Deno.test("[db] compareScore()", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way we could do this is to create an items array in the wrong order by score, then sort it via compareScore() and check the new order. This doesn't improve anything in a technical sense but does convey the intent and behaviour of the use of compareScore() to the reader. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds like a good idea! Will implement it towards the end of the week :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it in 153f423. This is way better than before. I also added a third item to not just switch the items from left to right.

const item1: Item = {
userId: crypto.randomUUID(),
title: crypto.randomUUID(),
url: `http://${crypto.randomUUID()}.com`,
...newItemProps(),
score: 1,
};
const item2: Item = {
userId: crypto.randomUUID(),
title: crypto.randomUUID(),
url: `http://${crypto.randomUUID()}.com`,
...newItemProps(),
score: 2,
};
const item3: Item = {
userId: crypto.randomUUID(),
title: crypto.randomUUID(),
url: `http://${crypto.randomUUID()}.com`,
...newItemProps(),
score: 5,
};

const aa = [item2, item3, item1];
const sorted = aa.toSorted(compareScore);

assertArrayIncludes(sorted, [item1, item2, item3]);
});

Deno.test("[db] getAreVotedBySessionId()", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add cases for when sessionId and sessionUser are falsy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the commit 19e3e33 if this is what you thought :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or wait you'll probably mean something like

 assertArrayIncludes(await getAreVotedBySessionId([item], null), []);

Do you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More like:

assertEquals(await getAreVotedBySessionId([item], undefined), []);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got you. That example came to my mind just before I opened this PR 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you prefer assertEquals or assertArrayIncludes in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertEquals will do the trick.

const item: Item = {
userId: crypto.randomUUID(),
title: crypto.randomUUID(),
url: `http://${crypto.randomUUID()}.com`,
...newItemProps(),
score: 1,
};

const user = genNewUser();
const vote = { item, user };

assertEquals(await getUserBySession(user.sessionId), null);
assertEquals(await getItem(item.id), null);
assertEquals(await getAreVotedBySessionId([item], user.sessionId), []);
assertEquals(await getAreVotedBySessionId([item], undefined), []);
assertEquals(
await getAreVotedBySessionId([item], "not-a-session"),
[],
);
assertEquals(
await getAreVotedBySessionId([item], crypto.randomUUID()),
[],
);

await createItem(item);

await createUser(user);
await createVote(vote);

assertEquals(await getItem(item.id), item);
assertEquals(await getUserBySession(user.sessionId), user);

assertEquals(await getAreVotedBySessionId([item], user.sessionId), [
true,
]);
});