Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix README spacing and numbering #238

Merged
merged 6 commits into from
May 30, 2023

Conversation

bqrkhn
Copy link
Contributor

@bqrkhn bqrkhn commented May 27, 2023

Fixes a few things in read.
See the updated readme here.

@iuioiua iuioiua requested a review from lambtron May 28, 2023 02:10
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run deno fmt.

@bqrkhn bqrkhn requested a review from iuioiua May 28, 2023 04:46
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Since we're here, could you please remove Docker as a prerequisite?

README.md Outdated

3. Listen locally to Stripe events:
3. Install [Stripe CLI](https://stripe.com/docs/stripe-cli#install)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Stripe CLI is already listed in the prerequisites section.

@bqrkhn bqrkhn requested a review from iuioiua May 30, 2023 04:16
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this, @Baqirkhan.

@iuioiua iuioiua changed the title Fix read me spacing & add stripe cli step docs: fix README spacing and numbering May 30, 2023
@iuioiua iuioiua merged commit 54d8b2a into denoland:main May 30, 2023
@iuioiua iuioiua mentioned this pull request May 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants