Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add .js + .jsx extension to tailwind content glob #2414

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: add .js + .jsx extension to tailwind content glob #2414

merged 1 commit into from
Apr 26, 2024

Conversation

kerimhudson
Copy link
Contributor

Whilst Deno supports Typescript by default, not everyone necessarily will want to write every file in Typescript. If using TailwindCSS, at the moment the files Tailwind searches for classes does not include .js and .jsx endings. Whilst you can manually add them via the tailwind.config.ts, it might be nice to have these added in by default for a better onboarding experience.

Closes #2291

Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks for making a PR 👍

@marvinhagemeister marvinhagemeister changed the title add js and jsx to tailwind content by default fix: add .js + .jsx extension to tailwind content glob Apr 26, 2024
@marvinhagemeister marvinhagemeister merged commit c98579e into denoland:main Apr 26, 2024
4 of 7 checks passed
@kerimhudson kerimhudson deleted the add-js-jsx-to-tailwind-content-default branch April 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tailwindcss not working in js/jsx files
2 participants