fix: allow multiple set-cookie headers to be set before render #2357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2346
The primary issue was the snippet
headers[key] = value
. This caused only oneset-cookie
to make it through. Switching to aHeaders
object allowed me to useappend
when appropriate, allowing for multipleset-cookie
entries.I also cleaned up one of the tests to make use of steps, because I originally broke it and couldn't immediately tell which part was failing.