Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow multiple set-cookie headers to be set before render #2357

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

deer
Copy link
Contributor

@deer deer commented Mar 10, 2024

closes #2346

The primary issue was the snippet headers[key] = value. This caused only one set-cookie to make it through. Switching to a Headers object allowed me to use append when appropriate, allowing for multiple set-cookie entries.

I also cleaned up one of the tests to make use of steps, because I originally broke it and couldn't immediately tell which part was failing.

Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@marvinhagemeister marvinhagemeister merged commit 5ec0635 into denoland:main Mar 12, 2024
6 of 7 checks passed
@deer deer deleted the 2346_cookie_issue branch March 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting multiple cookies before render will only send the last Set-Cookie header
2 participants