-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a PKCE authentication with Supabase example #2302
docs: add a PKCE authentication with Supabase example #2302
Conversation
71740f9
to
7267bfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great tutorial so far!
Thanks! Also for the prompt and thorough review. I'll be able to work on this tomorrow but before that, I have a couple of questions regarding the In my local testing, it does not seem to have any effect. In fact, I am suddenly able to run the app with neither using In general, for educational content like this, should I include the most precise run command |
You understand correctly.
Using specific permission flags instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more nits.
@thorwebdev, feel free to review if you'd like. |
dd7d6d8
to
cd3f3c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
Quick ping to see if this is still on the radar. Is there anything I can do to move this forward? |
Just awaiting Marvin's review 🙂 |
PTAL @marvinhagemeister |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for adding this 👍
Closes #1217
Adds an example on how to implement the PKCE authentication flow with Supabase.
I included a link to a repo of mine holding the code to a fully fleshed out example app as a more comprehensive point of reference, hope that is ok. In fact, I was thinking of deploying that app on Deno Deploy and add it to the Showcase section, lmk if that would be a good idea.