When specifying the path when importing, it is now easier to specify … #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the path from the root directory of the project. The method of specifying from "~/" is very straightforward. For example, using import Counter from "./islands/Counter.tsx" instead of import Counter from "~/islands/Counter.tsx". We believe that the former is less likely to lose the directory structure. Oops, I feel like I already know this. Anyway, this should be accepted as a memorable first directory notation...
iuioiua
suggested changes
Aug 1, 2023
There was a problem hiding this comment.
Can you please modify components, routes, islands, etc., to use this new import prefix?
|
I see. |
Change prefix Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
|
Oops, warn of types |
|
How should we deal with... |
|
This reminds me of #471. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method of specifying from
"~/"is very straightforward. For example, usingimport Counter from "./islands/Counter.tsx"instead ofimport Counter from "~/islands/Counter.tsx". We believe that the former is less likely to lose the directory structure.Oops, I feel like I already know this.
Anyway, this should be accepted as a memorable first directory notation...