This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Deno logo SVG, raster assets containing the logo, and improves some of the site head tags.
I hand crafted the new logo SVG to be optimal (e.g. avoid decimal coordinates) and precise (e.g. use perfect circle shapes); it's based on the logo in use at https://deno.com which has a simpler form:
https://deno.com/static/logo3.png
I couldn't find an SVG of this PNG logo anywhere, so I made one from scratch to perfectly match the artwork with the exception of the eye, which in the PNG image is dark green color for some reason. I'm not a fan of the top right raindrop placement causing only a tiny bit to be visible, but I decided to stay true to the "official" logo and not tweak the raindrop distribution. The new SVG logo is exactly two-color; pure white and black.
The new logo SVG works in both dark and light contexts, because the artwork within the circle contains white and black pixels vs attempting to use transparency and a single color that must be inverted via a
prefers-color-scheme
media query. This allows thelogo.svg
asset to be used both as the logo in the site header and as the SVG favicon, replacingfavicon.svg
. I would have preferred to rename the asset fromlogo.svg
to the more descriptivedeno-logo.svg
, but it's good to avoid breaking existing URLs referencing the asset (e.g. the logo in the denoland/deno repo readme).The new
logo.svg
asset file size has been reduced from 6,020 bytes down to 1,139 bytes.The apple-touch-icon has been much improved; the logo is now centered in whitespace and the resolution is much higher (512x512px vs 180x180px). Left is before, right is after:
The asset is now served at
/apple-touch-icon.png
instead of/images/icons/apple-touch-icon-180x180.png
so your server should see less 404's from bots and clients trying to scrape the well known asset. Because iOS Safari and other clients know to look for this URL by convention, instead of updating thelink rel="apple-touch-icon"
head tagsrc
the tag has been removed. This PNG has been optimized:The
favicon.ico
asset has been updated with two size layers:64x64px for sharp display compared to the maximum 48x48px layer in the old asset. In this screenshot from Preview app the grey represents transparent areas:
16x16px for old-school browsers on non-Retina screen devices. This layer has been artworked from scratch to remove the raindrops which are a blur at this small size, and increase the size of the Deno head and eye.
Compare that with the old icon, which would not have worked in a dark UI due to the face being transparent:
There are no intermediate size layers to reduce the download size of the favicon; the largest 64x64px layer can be dynamically sized down by the client as necessary.
Here you can see the after and before of both the header logo and the favicon…
After:
Before:
Darkmode SVG favicons, comparing after (left) and before (right):