fix: restore copy button in tabs #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolluset
commented
Jan 12, 2025
| textToCopy = textToCopy.replace(/^[\$>\s]+/, ""); | ||
| navigator?.clipboard?.writeText(textToCopy); | ||
| document.addEventListener("click", (event) => { | ||
| const btn = (event.target as HTMLElement).closest("button[data-copy]"); |
There was a problem hiding this comment.
The button has svg icons, so use closest to prevent missing copies.
| @@ -30,28 +30,6 @@ export default function codeblockCopyPlugin(md: any) { | |||
| </button> | |||
| `; | |||
|
|
|||
| const script = ` | |||
There was a problem hiding this comment.
Moved to the copy.client.ts file.
kt3k
reviewed
Jan 21, 2025
Comment on lines
+14
to
+16
| if (!btn) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
nit: I don't think this can be null or undefined even if the button was removed at this point
kt3k
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1292
I fixed the copy button in the tabs.
The reason the copy button in the tabs didn't work was because of the render order issue. So I moved the binding delegate to the document.
tested in local:
2025-01-12.2.53.22.mov