Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Update http-server-files.ts - Only read from static/ directory #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

louwers
Copy link

@louwers louwers commented Mar 31, 2024

This showcases Deno's security model a bit more I think.

@hashrock
Copy link
Contributor

hashrock commented Apr 1, 2024

maybe --allow-read=public,path ?

@@ -2,7 +2,7 @@
* @title HTTP Server: Serving Files
* @difficulty intermediate
* @tags cli, deploy
* @run --allow-net --allow-read <url>
* @run --allow-net --allow-read=static/ <url>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @run --allow-net --allow-read=static/ <url>
* @run --allow-net --allow-read=static/,path/to/file.txt <url>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hashrock Like this maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, and static/ -> public/ because of fsRoot option

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants